Add WebSocket support to httpcore5-websocket#613
Open
arturobernalg wants to merge 1 commit intoapache:masterfrom
Open
Add WebSocket support to httpcore5-websocket#613arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
Improve server handling and add extensive core tests/examples Align client usage with core WebSocket APIs Extend HTTP/2 request conversion and tests
Member
Author
|
A follow‑up PR will expose the client‑side pieces (see https://github.com/apache/httpcomponents-client/pull/762/changes). |
Member
|
@arturobernalg What is your plan? Do you want to provide the server side functionality out of the core project and the client side out of the client project? Should not the client protocol handler also go into core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve server handling and add extensive core tests/examples Align client usage with core WebSocket APIs
Extend HTTP/2 request conversion and tests
@ok2c DefaultH2RequestConverter has a minimal RFC 8441 change (handling :protocol for CONNECT). This is required for H2 WebSocket server support. I tried to keep it separated, but was impossible.