Skip to content

Comments

feat(ci): impl typos automatically checks#2803

Open
Svecco wants to merge 1 commit intoapache:masterfrom
Svecco:2802-typos-ci
Open

feat(ci): impl typos automatically checks#2803
Svecco wants to merge 1 commit intoapache:masterfrom
Svecco:2802-typos-ci

Conversation

@Svecco
Copy link
Contributor

@Svecco Svecco commented Feb 24, 2026

Issue

Referring #2802 , Consider implementing automated typo checking.

Rationale

Diff

  • fixed known, refactored some filenames/variables;
  • updated the ci/cd workflow to include typos checking;
  • modified the pre commit hooks, influence on prek;
  • relevant cfg have been introduced for exceptions;

Local Execution

Passed, and checked by clippy, prek, machete, also sort && fmt.

AI Usage

Didn't use

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.41%. Comparing base (d897efb) to head (d1437f5).

Files with missing lines Patch % Lines
core/common/src/commands/messages/send_messages.rs 0.00% 1 Missing and 1 partial ⚠️
core/server/src/io/storage.rs 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2803      +/-   ##
============================================
- Coverage     68.41%   68.41%   -0.01%     
  Complexity      656      656              
============================================
  Files           852      852              
  Lines         68182    68182              
  Branches      59643    59653      +10     
============================================
- Hits          46648    46647       -1     
+ Misses        19201    19193       -8     
- Partials       2333     2342       +9     
Flag Coverage Δ
csharp 67.06% <ø> (-0.19%) ⬇️
java 52.19% <ø> (ø)
rust 69.59% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ore/configs/src/configs_impl/typed_env_provider.rs 90.25% <100.00%> (ø)
core/consensus/src/plane_helpers.rs 20.56% <ø> (ø)
.../binary/handlers/messages/send_messages_handler.rs 100.00% <ø> (ø)
...Iggy_SDK/Exceptions/InvalidBaseAddressException.cs 0.00% <ø> (ø)
.../csharp/Iggy_SDK/Extensions/IggyClientExtension.cs 0.00% <ø> (ø)
core/server/src/io/storage.rs 0.00% <0.00%> (ø)
core/common/src/commands/messages/send_messages.rs 82.39% <0.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Svecco Svecco marked this pull request as draft February 24, 2026 05:56
@Svecco Svecco marked this pull request as ready for review February 24, 2026 06:11
@Svecco
Copy link
Contributor Author

Svecco commented Feb 24, 2026

WIP

.collect();

let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABELD", &known);
let suggestions = TypedEnvProvider::<TestConfig>::find_similar_vars("TEST_ENABLED", &known);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was deliberately mistake... check what is it testing (levenshtein distance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants