Enable/Disable sending of Metrics by properties in InfluxdbBackendListenerClient and InfluxDBRawBackendListenerClient#6476
Enable/Disable sending of Metrics by properties in InfluxdbBackendListenerClient and InfluxDBRawBackendListenerClient#6476dgetzlaf wants to merge 3 commits intoapache:masterfrom
Conversation
By this it is possible to enable/disable the sending of Metrics by properties (like in the Dynatrace/MINT Backend Listener)
By this it is possible to enable/disable the sending of Metrics by properties (like in the Dynatrace/MINT Backend Listener)
|
WDYT of something like #6478 instead? |
Hi @vlsi , But I'm not sure, if I'm missing something: |
Sure the idea is to support both UI and programmatic API. I just drafted the test first to see how complicated would it be to implement the basic features. I've drafted a UI as well: #6478 |
|
I understand your funny problem; in my opinion you should stick to "display conditionally enabled" as that's the default. This might also reduce the possible overhead/noice during an update of the testplan. But could your change lead to performance drop (number of executed sampler), since the |
That is right. However, the default case is that "enabled" is either unset or set to We should probably support case like |
Description
Introduce
listenerIsEnabledto InfluxdbBackendListenerClient and InfluxDBRawBackendListenerClient.By this it is possible to enable/disable the sending of Metrics by properties (like in the Dynatrace/MINT Backend Listener)
Motivation and Context
When running the same testplan in different environments, I can not always rely on the accessibility to my InfluxDB. (Here I get the log file spammed by errors that are preventable.)
With this, I can configure i.e. by properties or groovy code, if i can send metrics to my InfluxDB:
${__P(InfluxdbBackendListener.enabled, true)}${__groovy(org.apache.commons.lang3.SystemUtils.IS_OS_LINUX)}The idea is copied from the MintBackendListener.
By default the listener is always enabled and must be disabled explicitly.
How Has This Been Tested?
Locally tested the InfluxdbBackendListenerClient with
enabled=trueLog message "InfluxdbBackendListenerClient will send metrics: true"
and sending of metrics
enabled=falseLog message "InfluxdbBackendListenerClient will send metrics: false"
and NO sending of metrics
enabled=faaaaaalseLog message "InfluxdbBackendListenerClient will send metrics: false"
and NO sending of metrics
Types of changes
Checklist: