GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY#3270
Open
ArnavBalyan wants to merge 2 commits intoapache:masterfrom
Open
GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY#3270ArnavBalyan wants to merge 2 commits intoapache:masterfrom
ArnavBalyan wants to merge 2 commits intoapache:masterfrom
Conversation
Member
ArnavBalyan
commented
Aug 18, 2025
ArnavBalyan
commented
- The behaviour of BYTE_ARRAY or FIXED_LEN_BYTE_ARRAY for big decimals is not clear from the docs.
- Added code comments at the read/writer to make the behaviour more clear for the reader.
- Fixes Is big Decimal in Parquet big endian? #3246
Member
Author
|
cc @shangxinli @wgtmac could you please review thanks! |
wgtmac
reviewed
Aug 24, 2025
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * ValuesReader for variable-length {@code BYTE_ARRAY} columns. |
Member
There was a problem hiding this comment.
I don't think this is the good place to add the comment since this class is for a specific encoding of binary physical type.
As I have replied in the issue, the spec is clear on this so we don't even need the explaination.
Member
Author
There was a problem hiding this comment.
Thanks for the review, yes on retrospect code comment may not be the best, I'll check if the readme can be made more clear since the user pointed to the readme asking for clarity. Will iterate and get back thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.