GH-3289: Introduce Parquet E2E test harness to support CLI testing#3296
Open
ArnavBalyan wants to merge 6 commits intoapache:masterfrom
Open
GH-3289: Introduce Parquet E2E test harness to support CLI testing#3296ArnavBalyan wants to merge 6 commits intoapache:masterfrom
ArnavBalyan wants to merge 6 commits intoapache:masterfrom
Conversation
Member
Author
|
cc @gszadovszky as followup thanks! |
5d453a4 to
497858c
Compare
gszadovszky
requested changes
Sep 1, 2025
Contributor
gszadovszky
left a comment
There was a problem hiding this comment.
Thank you @ArnavBalyan for picking this up. It is a great improvement to improve the test coverage of the cli!
parquet-cli/src/test/java/org/apache/parquet/cli/ShowSizeStatisticsCliTest.java
Show resolved
Hide resolved
parquet-cli/src/test/java/org/apache/parquet/cli/commands/FileTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
cc @gszadovszky this is ready thanks! |
Contributor
|
@ArnavBalyan, could you check the failures? |
gszadovszky
approved these changes
Sep 5, 2025
Contributor
gszadovszky
left a comment
There was a problem hiding this comment.
Thanks, @ArnavBalyan.
Contributor
|
Oh, the tests are still failing... |
Member
Author
|
Strangely I am not seeing it locally let me fix it |
3f7caa8 to
57011ae
Compare
Contributor
|
@ArnavBalyan Gentle ping! Did you find some time to fix the test? |
Member
Author
|
Hi @Fokko thanks for the ping, I'll revive it in the coming week, looks like it was a formatting issue. Will try to fix soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linecount,partial matchetc.