WW-4421 Fix duplicate @Action annotation check being skipped (6.x backport)

[lukaszlenart]

Summary

• Backport of WW-4421 Fix duplicate @Action annotation check being skipped #1579 from Struts 7.x to Struts 6.x
• Fix duplicate @Action name detection being skipped when execute() is annotated with @Action
• Extract the duplicate check loop to run unconditionally before the conditional block in PackageBasedActionConfigBuilder.buildConfiguration()
• Add test fixtures and unit tests for both the previously-broken and already-working scenarios

Fixes WW-4421

Problem

The duplicate @Action name detection in PackageBasedActionConfigBuilder.buildConfiguration() was embedded inside a conditional block (!map.containsKey(DEFAULT_METHOD)) whose primary purpose is deciding whether to auto-create a mapping for execute(). When execute() is annotated with @Action, the condition is false and the entire duplicate detection is skipped — silently allowing two methods to map to the same action name, with one overwriting the other non-deterministically.

Changes

PackageBasedActionConfigBuilder.java — Moved the actionNames duplicate check loop before the if block so it runs for all annotated methods regardless of execute() annotation status. Added shouldMapDefaultExecuteMethod() helper method.

Test fixtures:

• DuplicateActionNameWithExecuteAnnotationAction — @Action("duplicate") on both execute() and another method (the previously undetected case)
• DuplicateActionNameWithoutExecuteAnnotationAction — unannotated execute() with two methods sharing @Action("duplicate") (regression guard)

PackageBasedActionConfigBuilderTest.java — Two new test methods verifying ConfigurationException is thrown in both scenarios.

Test plan

• testDuplicateActionNameWithAnnotatedExecute passes (new — validates the fix)
• testDuplicateActionNameWithoutAnnotatedExecute passes (regression guard)
• All convention plugin tests pass with no regressions

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate failed

Failed conditions
22 Security Hotspots
42.4% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE