F!! Add auto approve reporter based on system properties#447
Open
zabetak wants to merge 1 commit intoapprovals:masterfrom
Open
F!! Add auto approve reporter based on system properties#447zabetak wants to merge 1 commit intoapprovals:masterfrom
zabetak wants to merge 1 commit intoapprovals:masterfrom
Conversation
The new reporter will automatically approve the changeset (copy received to approved) when a specified System property is set (to true or it is simply present). The goal is to allow to update easily all relevant files from the tests that are run, without requiring code changes but in a controlled manner (only when the user explicitly sets the property).
Contributor
|
hey, we're back doing weekly sessions to work on ApprovalTests. Would you like to join on a Monday evening (18-20 o'clock), walk us through this PR and get this merged? |
Author
|
Monday 22/1 at 19:00 GMT +1 is fine with me. Feel free to send me an invite at zabetak@gmail.com |
Contributor
|
@zabetak FYI this is now possible using environment variable - https://github.com/approvals/ApprovalTests.Java/blob/master/approvaltests/docs/how_to/ConfigureReporters.md#method-4-environment-variables |
Author
|
Thanks for info @maio ! In a similar manner maybe it would be useful to allow to configure reporters via system properties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new reporter will automatically approve the changeset (copy received to approved) when a specified System property is set (to true or it is simply present).
The goal is to allow to update easily all relevant files from the tests that are run, without requiring code changes but in a controlled manner (only when the user explicitly sets the property).
The new auto approver would be very useful for projects using
maven,gradle, etc, where system properties can be passed along when running a test. For instance: