fix(rest): tolerate malformed x-ratelimit-reset in 429 handling#761
Open
MegaManSec wants to merge 1 commit intoauth0:masterfrom
Open
fix(rest): tolerate malformed x-ratelimit-reset in 429 handling#761MegaManSec wants to merge 1 commit intoauth0:masterfrom
x-ratelimit-reset in 429 handling#761MegaManSec wants to merge 1 commit intoauth0:masterfrom
Conversation
`Response.content()` cast the `x-ratelimit-reset` header to int without validation. If a 429 response included a non-integer (or garbage) value, `int()` raised ValueError and the call crashed instead of raising a structured `RateLimitError`. Parse defensively and fall back to `-1` when missing/malformed so clients always receive `RateLimitError` as intended. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response.content()cast thex-ratelimit-resetheader to int without validation. If a 429 response included a non-integer (or garbage) value,int()raised ValueError and the call crashed instead of raising a structuredRateLimitError. Parse defensively and fall back to-1when missing/malformed so clients always receiveRateLimitErroras intended.Testing
Simulate a server response with something like this:
Checklist