docs(readme): Document createUnsignedAssertion() and improve usage examples#75
Open
esarafianou wants to merge 1 commit intomasterfrom
Open
docs(readme): Document createUnsignedAssertion() and improve usage examples#75esarafianou wants to merge 1 commit intomasterfrom
esarafianou wants to merge 1 commit intomasterfrom
Conversation
4646240 to
e280c6f
Compare
luuuis
approved these changes
May 14, 2021
| }; | ||
|
|
||
| var signedAssertion = saml.create(options); | ||
| saml.create(options, (err, samlAssertion) => { |
Contributor
There was a problem hiding this comment.
Synchronous invocation is actually supported unless the encryptionCert option has been passed in, at which point callback becomes required. It's a bit silly but that's how the library has behaved.
Lines 261 to 263 in 06acc02
I'm ok with the change though.
e280c6f to
64562b3
Compare
64562b3 to
cc62493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
saml20.createUnsignedAssertion()andsaml11.createUnsignedAssertion()were added in version 0.15 but are not documented in READMEReferences
Testing
Only docs changes