Open
Conversation
Author
|
@godcrampy can you help push this along please? Scanning tools have been quite unhappy for some time about this. Fork test on a clean up to date repo was successful. https://github.com/curtdept/aws-lambda-nodejs-runtime-interface-client/actions/runs/21960662538 |
There was a problem hiding this comment.
Pull request overview
This PR aims to update the curl dependency from an older version to 8.18.0 to mitigate multiple CVEs. The change modifies the preinstall script to reference a version-specific subdirectory when extracting and building curl.
Changes:
- Updated
CURL_DIRpath in preinstall script to include version-specific subdirectory (curl-8.18.0)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the curl dependency to the latest released 8.18.0 and modifies the preinstall script to point to the appropriate subdirectory.
8.18.0 is needed to mitigate a large number of identified CVEs in this package since the previous bump.
Release information and package for curl: https://github.com/curl/curl/releases/tag/curl-8_18_0
Relates to: #159
Checklist
npm installto generate thepackage-lock.jsoncorrectly and included it in the PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.