use a string wrapper to support intl, mbstring and iconv extension#131
use a string wrapper to support intl, mbstring and iconv extension#131sandrokeil wants to merge 1 commit intobeberlei:masterfrom
Conversation
|
@sandrokeil I am unsure, it must be a new major version that is for sure, but i don't know if intl is as widespread as mbstring. |
lib/Assert/Assertion.php
Outdated
| * @method static void nullOrChoicesNotEmpty($values, $choices, $message = null, $propertyPath = null) | ||
| * @method static void nullOrMethodExists($value, $object, $message = null, $propertyPath = null) | ||
| * @method static void nullOrIsObject($value, $message = null, $propertyPath = null) | ||
| * @method static void nullOrDate($value, $format, $message = null, $propertyPath = null) |
|
@beberlei We can use a simple String Wrapper like Zend and we have a WinWin solution and can bring a new minor release. Maybe even simpler, check for the extensions on the appropriate functions and call the correct method. What do you think? The order is intl, mbstring and iconv. I will update the PR if you accept this. |
sandrokeil
changed the title
|
ping @beberlei +1 for string wrapper and full backward compatibility? We will support intl, mbstring, iconv and native. No method signature will be changed, but the encoding is only used by mbstring and iconv. |
|
👍 |
lib/Assert/Assertion.php
Outdated
| * @method static void allChoicesNotEmpty($values, $choices, $message = null, $propertyPath = null) | ||
| * @method static void allMethodExists($value, $object, $message = null, $propertyPath = null) | ||
| * @method static void allIsObject($value, $message = null, $propertyPath = null) | ||
| * @method static void allDate($value, $format, $message = null, $propertyPath = null) |
There was a problem hiding this comment.
Another removal?
Are you using bin/generate_method_docs.php to update the docblocks?
|
any update? |
5 participants
Since the PHP intl extension is available, there is no need to use mbstring anymore. Websites uses UTF-8 and PHP intl extension is more comfortable than mbstring. I've replaced all
mb_*functions with thegrapheme_*functions.@beberlei What do you think about a new major version which uses the PHP intl extension?