Conversation
| <div class="row"> | ||
| <div class="col-12 mt-4 text-end"> | ||
| {% if not sample.sample_remove_locked and not admin_mode %} | ||
| {% if not sample.sample_remove_locked %} |
There was a problem hiding this comment.
Wait, so before this, regular users could remove a sample from (their own) profile but admins could NOT remove a sample from a user's profile? Was there a reason for that?
There was a problem hiding this comment.
The decision to previously block admins from removing samples was driven by a few factors, mostly a combination of organizational composition and a desire/plan to build out tiered administrative privileges (in contrast to the current model where someone is either a normal user or has full administrative privileges). Since then, the former has changed and the latter has been shelved indefinitely, meaning it makes sense to restore this function for the foreseeable future.
AmandaBirmingham
left a comment
AmandaBirmingham
left a comment
There was a problem hiding this comment.
Ok, sounds good to me.
2 participants
This pull request grants admins the ability to remove samples from a profile (source) until the sample has been scanned by the wet lab. Once it has been scanned, admins will continue to be prevented from removing a sample, matching the behavior of normal users.
Additionally, I updated the word "source" in the confirmation message to "profile" to match the post-overhaul terminology displayed in the UI.