fix(coercion): fix non-value boolean flags#8
Merged
natemoo-re merged 1 commit intobombshell-dev:mainfrom Feb 24, 2025
Merged
Conversation
dreyfus92
approved these changes
Feb 23, 2025
natemoo-re
approved these changes
Feb 24, 2025
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
🙌 thanks for the great fix and tests!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
This pr fixes a bug I found which always set the long-form non-value boolean flags to
false, i.e.mycli --myboolwill output{ _: [], mybool: false }Here's a repro of the bug
Changes
coercefunction to properly set long-form non-value (undefined) boolean flags totrueChecks