Draft
Conversation
Adds completion config support and moves some things to the shared module. There will be a better way to share logic between these two even more but it hasn't yet clicked in my head.
|
Defines a `TabFunction` that all entrypoints export, such that we consistently support the same call signature.
43081j
force-pushed
the
consistent-function-type
branch
from
7f6a272 to
8c28a36
Compare
commit: |
dreyfus92
reviewed
Mar 3, 2025
Member
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
i like this idea, i can't think of anything that can bring challenges for the future tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines a
TabFunctionthat all entrypoints export, such that weconsistently support the same call signature.
cc @dreyfus92 this is what I had in mind. I'll leave it as a draft until we agree or disagree its a good thing to do. it may not be, happy to hear yours and the others' thoughts
Depends on (and includes) #17