Allow users to set activeTabset to undefined#326
Open
alexwaeseperlman wants to merge 2 commits intocaplin:masterfrom
Open
Allow users to set activeTabset to undefined#326alexwaeseperlman wants to merge 2 commits intocaplin:masterfrom
alexwaeseperlman wants to merge 2 commits intocaplin:masterfrom
Conversation
Author
|
Just checking in on the status of this PR |
can you elaborate on the usage of not needing this? I am interested in something similiar cc @alexwaeseperlman |
Author
|
For that project I ended up using my own fork |
Author
|
Hi this has been open for a while. Is there a reason why it was never reviewed? |
Collaborator
|
Hi Alex, I think changing Actions.setActiveTabset to accept undefined would be better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a way to not have a selected tab. I needed this feature for a project I'm working on with popout windows and I couldn't find another way to do it.