Conversation
bluwy
reviewed
Jan 27, 2026
Merged
bluwy
previously approved these changes
Jan 27, 2026
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
You know what would be cool? 😅 changesets/action#525
Anyways LGTM now 👍
s0
requested changes
Jan 27, 2026
.github/workflows/publish.yml
Outdated
Comment on lines
21
to
23
Member
There was a problem hiding this comment.
Need to also upgrade these for trusted publishing to work:
uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
with:
node-version: 24.xSee this PR in another repo with an equivalent change: ArcaneWizards/arcanejs#107
Member
Author
There was a problem hiding this comment.
I bumped all actions now
.github/workflows/publish.yml
Outdated
Comment on lines
39
to
40
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| NPM_CONFIG_PROVENANCE: true |
Member
There was a problem hiding this comment.
Suggested change
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | |
| NPM_CONFIG_PROVENANCE: true |
s0
approved these changes
Jan 27, 2026
s0
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've configured trusted publishing for
publish.ymlso we need to rename this file