Refactor opsqueue_service to use wait_for_server for port assignment and add utility function for server wait logic#34
Open
ReinierMaas wants to merge 6 commits intoreinier/log-bound-server-portfrom
Conversation
…nment and add utility function for server wait logic
There was a problem hiding this comment.
Pull request overview
This PR refactors the test infrastructure to dynamically detect server ports rather than pre-assigning them. The main change introduces a wait_for_server utility function that monitors a process until it starts listening on a port, eliminating the need for the previous random_free_port() approach.
Key Changes:
- Added a new
wait_for_server()utility function that polls a process usingpsutilto detect when it starts listening on a port - Modified
opsqueue_service()to usepsutil.Popeninstead ofsubprocess.Popenand dynamically discover the server port viawait_for_server() - Changed the default port parameter from
Noneto0, which allows the OS to assign an available port that is then discovered
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| libs/opsqueue_python/tests/util.py | New utility module containing wait_for_server() function with retry logic to wait for a process to start listening on a port |
| libs/opsqueue_python/tests/conftest.py | Updated opsqueue_service() to use psutil.Popen and call wait_for_server() for dynamic port discovery instead of pre-assigning ports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…` assignment and add utility function for server wait logic
Qqwy
approved these changes
Dec 30, 2025
…` assignment and add utility function for server wait logic
Contributor
Author
|
Locally I can reproduce the following error (and I haven't got the time to look into Maybe we need to update the nixpkgs pin to make this work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
opsqueue_serviceto usewait_for_serverfor port assignment and add utility function for server wait logic.