Makes passing the 'rustToolchain' optional when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix #60
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix They can still be overridden by specifying a different Rust version in the overlay. But if kept at its default, will use the version from the `rust-toolchain.toml` in the opsqueue repo itself.
Contributor
Author
|
@OpsBotPrime merge |
Contributor
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
Contributor
Author
|
@OpsBotPrime merge on Friday |
Contributor
|
Rebased as 87d250d, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes passing the 'rustToolchain' optional when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix.
They can still be overridden by specifying a different Rust version in the overlay. But if kept at its default, will use the version from the
rust-toolchain.tomlin the opsqueue repo itself.By making this optional, users of the library do not need to care about which Rust version they are using. Except that if they are using a particular version for other parts of their software, they can ensure they use the same (to prevent building deps twice, for example).