fix(greenhouse): prevent wide content from causing page-level horizontal scrollbar#1477
Open
fix(greenhouse): prevent wide content from causing page-level horizontal scrollbar#1477
Conversation
…tal scrollbar Add min-w-0 constraint chain to layout containers and overflow-x-auto to catch unhandled wide content. This prevents components like YamlViewer from pushing the shell layout wider. Changes: - styles.css: Change #root from display:inline to flex with min-width:0 - ShellLayout: Add min-w-0 to grid and wrapper, overflow-x-auto to main - YamlViewer: Add overflow-x-auto and max-w-full to container
🦋 Changeset detectedLatest commit: a0c3b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TilmanHaupt
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1476
This PR addresses the layout issue where wide content in the
YamlViewercomponent (and potentially other components) causes the entire Greenhouse shell to expand horizontally, resulting in a page-level scrollbar.Changes
overflow-x-auto max-w-fullto container for component-level scrolling#rootfromdisplay: inlinetodisplay: flexwithmin-width: 0to establish constraint foundationmin-w-0constraint chain andoverflow-x-autocatch-all on main content areaHow it works
The fix uses a
min-w-0constraint chain from#rootdown through the shell layout. In CSS flexbox/grid, the defaultmin-width: autoprevents items from shrinking below their content size. Addingmin-w-0allows containers to respect their parent boundaries.Graceful degradation
Why NOT
overflow-hiddenat layout level?Juno UI components use portals for Modals, Select dropdowns, ComboBox, PopupMenus, and Tooltips. Adding
overflow-hiddento layout containers would clip these portaled elements. Themin-w-0+overflow-x-autoapproach avoids this issue.Test plan