Update test suite to use new reactphp/async package instead of clue/reactphp-block#57
Merged
Update test suite to use new reactphp/async package instead of clue/reactphp-block#57
Conversation
clue
approved these changes
Apr 10, 2024
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings @dinooo13 Thanks for looking into this, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a continuation of #50 and adds reactphp/async to replace the deprecated clue/reactphp-block dependency. Thank you @dinooo13 for doing most of the work on this! 💪
After building on top of #50, I also added reactphp/promise-timer as a dev-dependency. We initially installed reactphp/promise-timer through either reactphp/socket or reactphp/dns, but the ReactPHP Socket component removed its reactphp/promise-timer dependency in
v1.13.0and the ReactPHP DNS component did the same inv1.11.0.Builds on top of #50, clue/reactphp-block#67, clue/reactphp-block#68, reactphp/http#464, reactphp/socket#305 and clue/reactphp-mq#34
Closes #50