Skip to content

Conversation

@raphael-goetz
Copy link
Member

Resolves: #232

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new runtime definition for a "value" function in the control namespace (std::control::value), which appears to be a pass-through function that accepts a value of generic type R and returns it. The change resolves issue #232 and includes both the function definition and an audit log entry.

Changes:

  • Added new runtime definition file for std::control::value function with generic type support
  • Updated control-audit.md to document the addition on 06.02.2026

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
definitions/standard/runtime_definition/control/std_control_value.proto.json New runtime definition for the value function with generic type R, following the standard JSON schema structure
definitions/standard/runtime_definition/control/control-audit.md Added audit log entry documenting the addition of the value function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…lue.proto.json

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
@raphael-goetz raphael-goetz marked this pull request as ready for review February 6, 2026 14:33
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking it's not creating a value. its saving a value as a variable, so the naming of this new function should reflect this

@raphael-goetz
Copy link
Member Author

Generally speaking it's not creating a value. its saving a value as a variable, so the naming of this new function should reflect this

Do you have a suggestion? I know it's not creating a new value but I think it would be misleading when we call it Save Value?

@nicosammito
Copy link
Contributor

Generally speaking it's not creating a value. its saving a value as a variable, so the naming of this new function should reflect this

Do you have a suggestion? I know it's not creating a new value but I think it would be misleading when we call it Save Value?

I would just name it set variable

@raphael-goetz raphael-goetz merged commit 94c8d8e into main Feb 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Value Function

2 participants