-
Notifications
You must be signed in to change notification settings - Fork 0
New Value Function #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Value Function #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new runtime definition for a "value" function in the control namespace (std::control::value), which appears to be a pass-through function that accepts a value of generic type R and returns it. The change resolves issue #232 and includes both the function definition and an audit log entry.
Changes:
- Added new runtime definition file for
std::control::valuefunction with generic type support - Updated control-audit.md to document the addition on 06.02.2026
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| definitions/standard/runtime_definition/control/std_control_value.proto.json | New runtime definition for the value function with generic type R, following the standard JSON schema structure |
| definitions/standard/runtime_definition/control/control-audit.md | Added audit log entry documenting the addition of the value function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/control/std_control_value.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/control/std_control_value.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/control/std_control_value.proto.json
Show resolved
Hide resolved
…lue.proto.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
nicosammito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking it's not creating a value. its saving a value as a variable, so the naming of this new function should reflect this
Do you have a suggestion? I know it's not creating a new value but I think it would be misleading when we call it |
I would just name it set variable |
Resolves: #232