Delegate getValue/setValue in DefaultBuildContext to legacy build API#108
Merged
laeubi merged 1 commit intocodehaus-plexus:masterfrom Feb 5, 2026
Merged
Conversation
laeubi
approved these changes
Feb 4, 2026
Collaborator
|
I think formally one should only use the get/set values if |
Collaborator
|
@Volodjam you need to run 'mvn spotless:apply' to fix formating violations. |
This prevents objects from being stored in the singleton DefaultBuildContext instead of the thread-local build context (ThreadBuildContext) in Eclipse, avoiding unintended cross-project state sharing.
Volodjam
force-pushed
the
pr/delegate-values-to-legacy
branch
from
5a9a8b6 to
1f8b782
Compare
Contributor
Author
|
Done. Formatting issues are fixed and the branch has been force-pushed. |
Collaborator
|
Thanks for spotting this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents objects from being stored in the singleton DefaultBuildContext instead of the thread-local build context (ThreadBuildContext) in Eclipse, avoiding unintended cross-project state sharing.
Fix #107