Patchwork PR for Updating SDK Docs with Claude#14
Open
codelion wants to merge 20 commits intoclaude-only-index-runfrom
Open
Patchwork PR for Updating SDK Docs with Claude#14codelion wants to merge 20 commits intoclaude-only-index-runfrom
codelion wants to merge 20 commits intoclaude-only-index-runfrom
Conversation
codelion
force-pushed
the
patchwork-claude-only-index-run
branch
from
25adbaa to
9ec2e53
Compare
added 20 commits
August 19, 2024 23:33
…dk/selected-team-switcher.mdx
…dk/password-reset.mdx
…dk/magic-link-sign-in.mdx
…dk/stack-theme.mdx
…dk/stack-handler.mdx
…dk/forgot-password.mdx
…dk/account-settings.mdx
…dk/email-verification.mdx
…dk/credential-sign-in.mdx
…dk/oauth-button-group.mdx
…dk/oauth-button.mdx
…dk/stack-provider.mdx
…dk/credential-sign-up.mdx
…dk/use-stack-app.mdx
…dk/message-card.mdx
…dk/user-button.mdx
codelion
force-pushed
the
patchwork-claude-only-index-run
branch
from
9ec2e53 to
a43cbea
Compare
N2D4
reviewed
Aug 23, 2024
N2D4
left a comment
N2D4
left a comment
There was a problem hiding this comment.
Looks quite good already, but can it do the StackClientApp, StackServerApp, and StackAdminApp classes yet?
|
|
||
| ## Parameters | ||
|
|
||
| - `props`: `SelectedTeamSwitcherProps` - An object containing the following properties: |
| import { useUser } from "@stackframe/stack"; | ||
| - `options` (optional): `GetUserOptions` - Options for retrieving user information. | ||
| - `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated. | ||
| - `projectIdMustMatch` (optional): `'internal'` - Ensures the user belongs to an internal project. |
There was a problem hiding this comment.
This type is incorrect, it should be string, not 'internal'. This type is incorrect, it should be 'redirect' | 'throw' | 'return-null' (where the third is the default). I believe the AI got confused by the many overloads of this function
| ```jsx | ||
| import { useUser } from "@stackframe/stack"; | ||
| - `options` (optional): `GetUserOptions` - Options for retrieving user information. | ||
| - `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated. |
There was a problem hiding this comment.
This type is incorrect, it should be 'redirect' | 'throw' | 'return-null' (where the third is the default). I believe the AI got confused by the many overloads of this function
|
|
||
| ## Parameters | ||
|
|
||
| - `props`: `UserButtonProps` - Properties for configuring the UserButton component. |
There was a problem hiding this comment.
This should show the properties of UserButtonProps instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request from patchwork updates 20 SDK Docs