added unsigned char casting for errors in esp-idf building system#127
Open
FBEZ wants to merge 1 commit intocodeplea:masterfrom
Open
added unsigned char casting for errors in esp-idf building system#127FBEZ wants to merge 1 commit intocodeplea:masterfrom
FBEZ wants to merge 1 commit intocodeplea:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While porting
tinyexprto [Espressif's ESP-IDF](https://github.com/espressif/esp-idf), I encountered a compiler warning related to the use ofsigned chartypes in theisalphaandisdigitmacros:This appears to be a platform-specific issue. I wasn’t able to reproduce the same warning on macOS, even when explicitly setting the compiler flags:
Since I’m considering using your nice project as an example of how to port a C library as an ESP-IDF component, I wanted to contribute this small fix and share it back with you—this way, I can reference your repo directly in my write-up.
Thanks for maintaining such a clean and minimal implementation! :)