Skip to content

Issue 46 add custom 404 page#82

Open
saltyypringle wants to merge 7 commits intomainfrom
issue-46-Add_custom_404_page
Open

Issue 46 add custom 404 page#82
saltyypringle wants to merge 7 commits intomainfrom
issue-46-Add_custom_404_page

Conversation

@saltyypringle
Copy link
Collaborator

@saltyypringle saltyypringle commented Feb 4, 2026

Change Summary

Made a custom 404 page with a bunch of game trivia from the internet

Change Form

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

You can test it by trying any url that doesn't exist

Related issue

saltyypringle and others added 3 commits February 7, 2026 14:47
Co-authored-by: James Lee <82937700+SafetyInObscurity@users.noreply.github.com>
Copy link
Collaborator

@SafetyInObscurity SafetyInObscurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but may need to be compacted on a mobile view, so you don't need to scroll down to the quiz when it starts

Comment on lines +100 to +106
if (option === currentTrivia.answer) {
return `${baseClass} bg-accent border-accent text-accent-foreground font-semibold`;
}

if (option === selectedAnswer && option !== currentTrivia.answer) {
return `${baseClass} bg-secondary border-secondary text-secondary-foreground`;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Swap these colours around so it's easier to differentiate between colours

Suggested change
if (option === currentTrivia.answer) {
return `${baseClass} bg-accent border-accent text-accent-foreground font-semibold`;
}
if (option === selectedAnswer && option !== currentTrivia.answer) {
return `${baseClass} bg-secondary border-secondary text-secondary-foreground`;
}
if (option === currentTrivia.answer) {
return `${baseClass} bg-primary border-accent text-accent-foreground font-semibold`;
}
if (option === selectedAnswer && option !== currentTrivia.answer) {
return `${baseClass} bg-accent border-secondary text-secondary-foreground`;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom 404 page

3 participants