Issue 77 incorporate playable games into individual game pages #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rporate_playable_games_into_individual_game_pages
…ividual_game_pages
TobbleCobble
requested review from
SafetyInObscurity,
laurenpudz and
samjjacko
laurenpudz
requested changes
Feb 10, 2026
|
|
||
| return ( | ||
| <div | ||
| className={`flex items-center justify-center border-[26px] border-accent bg-background [clip-path:polygon(20px_20px,calc(100%-20px)_20px,100%_32px,100%_30%,calc(100%-20px)_45%,calc(100%-20px)_calc(100%-8px),80%_calc(100%-8px),75%_calc(100%-20px),20px_calc(100%-20px),0%_60%,0%_30%,20px_25%)]`} |
Contributor
There was a problem hiding this comment.
Is this the exact same border that is used in the landing page frame? If so, can we refactor it out to avoid repeating it?
Comment on lines
+91
to
+99
| {gameEmbedID != "0" ? ( | ||
| <div className="flex justify-center"> | ||
| <GameEmbed | ||
| embedID={gameEmbedID} | ||
| gameWidth={gameWidth} | ||
| gameHeight={gameHeight} | ||
| gameImage={gameCover} | ||
| /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Is it possible that we can supply a game embed but not a gameWidth, height or image? If this is possible, is there a case to catch this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The cover image on the game page is now replaced by an iframe linked to itch. Database now stores values for game embed id, game width and game height. If there is no value for game embed id, the game page will still show the cover image
Change Form
Other Information
Game scaling may not be an exact match to itch, but this shouldn't be a problem for most games
Related issue