fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'

[AdrianDC]

Description

fix(pre-commit-hooks)!: move 'check' to 'args' for global options

Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
arguments for example from a arguments configuration

fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'

Details: Pushing the same history from 'develop' to 'staging' for
example fails because range 'origin/HEAD..HEAD' is empty

No commit found with range: 'origin/HEAD..HEAD'

Checklist

• Add test cases to all the changes you introduce
• Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
• Test the changes on the local machine manually
• Update the documentation for the changes

Expected behavior

Error No commit found with range: 'origin/HEAD..HEAD' not raised

Steps to Test This Pull Request

Push same history to develop then staging

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4@737c24c). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff          @@
##             v4    #1209   +/-   ##
=====================================
  Coverage      ?   97.57%           
=====================================
  Files         ?       55           
  Lines         ?     2516           
  Branches      ?        0           
=====================================
  Hits          ?     2455           
  Misses        ?       61           
  Partials      ?        0           

Flag	Coverage Δ
unittests	97.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[woile]

@Lee-W thoughts on this? LGTM

[Lee-W]

Looks good to me. but we probably won't want to bump a major version for it. so I would suggest we remove the ! in all the commits

[AdrianDC]

Thanks for the feedback.

IMO this should be a ! change, as any user having args: [] as I used to will have local and CI breakages.

Could go along other fixes such as #1206 and #1207

Example local usage until released: https://gitlab.com/RadianDevCore/tools/gcil/-/blob/53e6cb534ff77704ac9b9dc51d755b9965556910/.pre-commit-config.yaml#L54

[Lee-W]

If that's the case, we'll need to wait for our next release. @woile we probably can create a v4 branch already?

[Lee-W]

Just change the base to v4. and let's merge it 🚀