Conversation
aman19K
reviewed
Feb 3, 2026
| this.assetsUidMap[uid] = response.uid; | ||
| this.assetsUrlMap[url] = response.url; | ||
| // Track assets with valid publish_details for deferred publishing | ||
| if (!isEmpty(publish_details)) { |
Contributor
There was a problem hiding this comment.
@netrajpatel , With this approach, we lose locale and environment context. We end up blindly publishing assets, entries, and variant entries across all locales and environments. This also ignores entry and variant entry localization scenarios.
In my opinion, we should simply move the existing publish logic into publish module. Before starting the publish process for each module, we can read from these files in the same way we currently do. This avoids the need to store the entire publish information in memory, which could otherwise lead to memory issues.
aman19K
requested changes
Feb 3, 2026
| const entriesWithPublishDetails: Set<string> = new Set(); | ||
| for (const entry of apiContent) { | ||
| if (!isEmpty(entry.publish_details)) { | ||
| const validPublishDetails = entry.publish_details.filter((pubDetail: any) => |
Contributor
There was a problem hiding this comment.
| if (this.failedVariantEntries.has(variantEntry.uid)) continue; | ||
|
|
||
| if (!isEmpty(variantEntry.publish_details)) { | ||
| const validPublishDetails = variantEntry.publish_details.filter((pd: any) => |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer publish introduced for Asset, Entries and Variant Entries