-
Notifications
You must be signed in to change notification settings - Fork 24
Update token.md - Include COW in BNB address #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add address to BNB version of COW. Did not include footnote as the bridged token does use stargate and not a native bridge. Thread with context and validation of token address: https://cowservices.slack.com/archives/C06G1E3AU77/p1758625335858369
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughBNB entry in the COW token addresses table ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/governance/token.md`:
- Line 22: The BNB token address row in the markdown table uses a plain link but
should match the other entries by wrapping the address in backticks; update the
BNB row (the line containing "BNB" and the link to bscscan token
0x5bfdaa3f7c28b9994b56135403bf1acea02595b0) so the linked address is enclosed in
backticks (e.g., `0x5bf...95b0`) while preserving the existing markdown link
target and spacing for consistency and copy/paste parity with the other address
entries.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/governance/token.md`:
- Line 22: The BNB table row contains an unofficial token address
`0x5bfdaa3f7c28b9994b56135403bf1acea02595b0`; revert the BNB entry in
docs/governance/token.md so the BNB row reads "N/A" instead of that address
(i.e., replace the table cell content for the BNB row that currently contains
the address with "N/A") to match official CoW Protocol deployments.
Add address to BNB version of COW.
Did not include footnote as the bridged token does use stargate and not a native bridge.
Thread with context and validation of token address: https://cowservices.slack.com/archives/C06G1E3AU77/p1758625335858369
Description
Changes
Summary by CodeRabbit