made it possible to create a TokenList from a buffer#347
made it possible to create a TokenList from a buffer#347firewave merged 3 commits intodanmar:masterfrom
TokenList from a buffer#347Conversation
|
Still need to integrate/test it with #261 to make sure it does not introduce any issues. It is already actively used by |
|
Some tests are still failing - will investigate. |
|
The tests failing are the ones with binary characters in the string. We need to add an additional |
StdStringStream which reads from a std::stringTokenList from a abuffer
TokenList from a abufferTokenList from a buffer
71a7916 to
32f1606
Compare
|
I changed it from a The tests pass but it produces valgrind failures in #261. |
32f1606 to
1895980
Compare
The issue has been fixed - see https://github.com/danmar/simplecpp/actions/runs/8484373804/job/23247192053?pr=261. |
TokenList from a bufferTokenList from a buffer
|
I will provide a downstream PR which shows this is working within Cppcheck. We should also do the (planned) release before merging this. |
|
@firewave would you like that I release simplecpp now or do you have some more fixes..? |
| } | ||
|
|
||
| virtual int get() OVERRIDE { | ||
| if (pos >= size) |
There was a problem hiding this comment.
These checks are still a hot spot. No idea if there is a way to implement this in a more performant way.
|
Here is the downstream PR using char buffers instead of streams: danmar/cppcheck#6379. |
|
Ready for review since the downstream PR passes all tests. |
|
@firewave you should have gotten an invite for this project. I hope you can merge.. |
@danmar Thanks. |
No description provided.