added TokenList constructors with modern buffer wrappers and hide "unsafe" ones - if available#496
Merged
firewave merged 6 commits intodanmar:masterfrom Aug 29, 2025
Merged
Conversation
Collaborator
Author
|
Supersedes #377. |
firewave
changed the title
TokenListTokenList out-of-the-box
firewave
changed the title
TokenList out-of-the-boxTokenList API
firewave
force-pushed
the
unsafe-api
branch
4 times, most recently
from
333f2dd to
8313678
Compare
firewave
changed the title
TokenList APITokenList constructor with modern buffer wrappers and made it possible to hide "unsafe" ones
firewave
force-pushed
the
unsafe-api
branch
7 times, most recently
from
4229d04 to
ea3a026
Compare
Collaborator
Author
|
This came up in a discussion in danmar/cppcheck#6379. |
Collaborator
Author
|
The added test is only to make sure it compiles. I will leverage #261 so it will actually be used for the input. |
firewave
force-pushed
the
unsafe-api
branch
2 times, most recently
from
ddc8da8 to
ae24823
Compare
Collaborator
Author
|
Not sure about the |
Collaborator
Author
|
We could also add an overload with |
Collaborator
Author
Or |
danmar
approved these changes
Aug 28, 2025
…e it possible to hide "unsafe" ones
Collaborator
Author
|
I renamed the define to |
firewave
changed the title
TokenList constructor with modern buffer wrappers and made it possible to hide "unsafe" onesTokenList constructors with modern buffer wrappers and made it possible to hide "unsafe" ones
firewave
changed the title
TokenList constructors with modern buffer wrappers and made it possible to hide "unsafe" onesTokenList constructors with modern buffer wrappers and hide "unsafe" ones - if available
danmar
reviewed
Aug 29, 2025
danmar
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.