Skip to content

Comments

chore: Deprecate invoke methods#1666

Open
javier-aliaga wants to merge 7 commits intodapr:masterfrom
javier-aliaga:deprecate-invoke-sdk-methods
Open

chore: Deprecate invoke methods#1666
javier-aliaga wants to merge 7 commits intodapr:masterfrom
javier-aliaga:deprecate-invoke-sdk-methods

Conversation

@javier-aliaga
Copy link
Contributor

Description

The guidance since 2023 has been to not use SDK invoke* methods for Service Invocation. However this has never been formalised by marking the methods as deprecated.

Instead it is recommended to use language native http clients and grpc clients for Service Invoke.

Factory methods in the SDK which return a native http/grpc client is fine too, and are not deprecated.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1642

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@siri-varma
Copy link
Contributor

@javier-aliaga quick question, do we need to update the javadoc on the pr suggesting the new approach ? May be it would good to update the examples as well ?

@javier-aliaga
Copy link
Contributor Author

@olitomlinson this will not be part of 1.17, as Siri pointed we have tests and examples to update and it will take some time to replace them. I will plan this for 1.18

salaboy
salaboy previously approved these changes Feb 23, 2026
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@javier-aliaga javier-aliaga force-pushed the deprecate-invoke-sdk-methods branch 2 times, most recently from 50b0163 to 07f4792 Compare February 23, 2026 14:38
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga force-pushed the deprecate-invoke-sdk-methods branch from 07f4792 to 1feb5cf Compare February 23, 2026 14:39
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.48%. Comparing base (5cca2f0) to head (1feb5cf).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1666      +/-   ##
============================================
+ Coverage     79.46%   79.48%   +0.01%     
+ Complexity     2192     2191       -1     
============================================
  Files           237      237              
  Lines          6575     6575              
  Branches        729      729              
============================================
+ Hits           5225     5226       +1     
+ Misses          996      994       -2     
- Partials        354      355       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ALL SDKS] Deprecate Invoke* SDK methods used for Service Invocation

3 participants