Simplify ssh config management #4453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
force-pushed
the
ssh-tunnel-ide-config
branch
from
3617fc2 to
b563b61
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
reviewed
Feb 6, 2026
| return "", fmt.Errorf("failed to check if secret scope %s exists: %w", secretScopeName, err) | ||
| } | ||
|
|
||
| if scope != nil && err == nil { |
Contributor
There was a problem hiding this comment.
Is the scope != nil check redundant when err == nil?
Contributor
Author
There was a problem hiding this comment.
The scope can be a default value with empty secrets
anton-107
reviewed
Feb 6, 2026
anton-107
requested changes
Feb 6, 2026
Contributor
anton-107
left a comment
anton-107
left a comment
There was a problem hiding this comment.
please double check the escaping sequence for SetEnv
ilia-db
force-pushed
the
ssh-tunnel-ide-config
branch
from
b563b61 to
fa28809
Compare
ilia-db
force-pushed
the
ssh-tunnel-ide-flag
branch
from
947c492 to
b5cc387
Compare
ilia-db
force-pushed
the
ssh-tunnel-ide-config
branch
from
fa28809 to
f86fdf3
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
force-pushed
the
ssh-tunnel-ide-config
branch
from
f86fdf3 to
149ebf9
Compare
ilia-db
force-pushed
the
ssh-tunnel-ide-flag
branch
from
8f4f92d to
abb3157
Compare
ilia-db
force-pushed
the
ssh-tunnel-ide-config
branch
from
149ebf9 to
1595782
Compare
ilia-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
anton-107
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Simplify sshd config management, so we can easily re-use it. The main change is that we add one "include" directive to the system ssh config, and all new host configs are encapsulated in single files, which are easy to replace or add.
Here we also solve a separate logic of proper escaping env vars, as before we were letting new lines sneak into SetEnv directive, which is not allowed
Based on #4452
Why
Tests