direct: plan: add new "empty" rule to replace empty{slice,map,struct} #4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
approved these changes
Feb 11, 2026
pietern
approved these changes
Feb 11, 2026
| >>> [CLI] auth profiles | ||
| Name Host Valid | ||
| test [DATABRICKS_URL] NO | ||
| test [DATABRICKS_URL] YES |
Contributor
There was a problem hiding this comment.
What's going on here? Looks racy...
Contributor
Author
There was a problem hiding this comment.
Indeed, I got this locally but it failed on CI. Reverting.
Contributor
Author
There was a problem hiding this comment.
It's not a race condition, I get YES consistently on my laptop.
Interestingly, YES is correct answer here as was added originally in https://github.com/databricks/cli/pull/3659/changes#diff-57b881487b436a3f618f7247532d8579c6f0d6de170708025bc70390aca79169R7
When SDK was bumped, it was changed to NO with this explanation:
Badness = "databricks auth profiles should return yes for the test profile. There's something going wrong with CLI detection in the SDK which makes this flag it as a legacy CLI."
perhaps @shreyas-goenka has some context.
Contributor
Author
There was a problem hiding this comment.
I stopped getting YES once I brew-uninstalled 'databricks'.
Contributor
There was a problem hiding this comment.
perhaps @shreyas-goenka has some context
This is a regression caused by the SDK bump. If you have the databricks CLI in path this passes otherwise fails. @tejaskochar-db was looking into this more.
Collaborator
|
Commit: 3f60147
18 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 1114335
30 interesting tests: 12 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New "empty" reason in plan triggers when old/new & remote values are all either nil or zero or empty slice/map.
Why
Ignoring differences like nil vs "" and nil vs 0 reduces drift when backend has preferred representation. For example, model_serving_endpoints.description is converted from nil to "" by backend. jobs.timeout_seconds has a default 0.
This supports removing server_side_default rule which currently marks this changes as "skip". #4490
Tests
Existing tests.