Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cmd/root/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,9 @@ func MustWorkspaceClient(cmd *cobra.Command, args []string) error {
}

_, isTargetFlagSet := targetFlagValue(cmd)
// If the profile flag is set but the target flag is not, we should skip loading the bundle configuration.
if !isTargetFlagSet && hasProfileFlag {
// Non-bundle commands should not implicitly load bundle auth config.
// Bundle target resolution is only enabled when the target/environment flag is set explicitly.
if !isTargetFlagSet {
cmd.SetContext(SkipLoadBundle(cmd.Context()))
}

Expand Down
83 changes: 83 additions & 0 deletions cmd/root/auth_bundle_loading_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
package root

import (
"context"
"os"
"path/filepath"
"testing"

"github.com/databricks/cli/internal/testutil"
"github.com/databricks/cli/libs/cmdctx"
"github.com/spf13/cobra"
"github.com/stretchr/testify/require"
)

func newWorkspaceAuthTestCommand() *cobra.Command {
cmd := &cobra.Command{}
cmd.SetContext(context.Background())
initProfileFlag(cmd)
initTargetFlag(cmd)
initEnvironmentFlag(cmd)
return cmd
}

func TestMustWorkspaceClientIgnoresBundleWithoutTargetFlag(t *testing.T) {
testutil.CleanupEnvironment(t)

rootDir := t.TempDir()
testutil.Chdir(t, rootDir)

err := os.WriteFile(filepath.Join(rootDir, "databricks.yml"), []byte(`
bundle:
name: test
targets:
dev:
default: true
workspace:
host: https://dev-environment.cloud.databricks.com
`), 0o644)
require.NoError(t, err)

t.Setenv("DATABRICKS_HOST", "https://stg-environment.cloud.databricks.com")
t.Setenv("DATABRICKS_TOKEN", "stg-token")

cmd := newWorkspaceAuthTestCommand()
err = MustWorkspaceClient(cmd, nil)
require.NoError(t, err)

cfg := cmdctx.ConfigUsed(cmd.Context())
require.NotNil(t, cfg)
require.Equal(t, "https://stg-environment.cloud.databricks.com", cfg.Host)
}

func TestMustWorkspaceClientUsesBundleWhenTargetFlagIsSet(t *testing.T) {
testutil.CleanupEnvironment(t)

rootDir := t.TempDir()
testutil.Chdir(t, rootDir)

err := os.WriteFile(filepath.Join(rootDir, "databricks.yml"), []byte(`
bundle:
name: test
targets:
dev:
default: true
workspace:
host: https://dev-environment.cloud.databricks.com
`), 0o644)
require.NoError(t, err)

t.Setenv("DATABRICKS_HOST", "https://stg-environment.cloud.databricks.com")
t.Setenv("DATABRICKS_TOKEN", "stg-token")

cmd := newWorkspaceAuthTestCommand()
err = cmd.Flag("target").Value.Set("dev")
require.NoError(t, err)

err = MustWorkspaceClient(cmd, nil)
require.NoError(t, err)

cfg := cmdctx.ConfigUsed(cmd.Context())
require.NotNil(t, cfg)
require.Equal(t, "https://dev-environment.cloud.databricks.com", cfg.Host)
}