Skip to content

Allow single and double quotes in environment dependencies #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 1 commit into from
Feb 13, 2026
+11 −0
Merged

Allow single and double quotes in environment dependencies #4511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions acceptance/bundle/environments/dependencies/databricks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ resources:
client: "1"
dependencies:
- "-r ./requirements.txt"
- -r "${workspace.file_path}/Path With Spaces/requirements.txt"
- "-r '${workspace.file_path}/Path With Spaces/requirements.txt'"
- "-e ./file.py"
- "-i http://myindexurl.com"
- "--index-url http://myindexurl.com"
Expand Down
4 changes: 4 additions & 0 deletions acceptance/bundle/environments/dependencies/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Deployment complete!
"client": "1",
"dependencies": [
"-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
"-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
"-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
"-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
"-i http://myindexurl.com",
"--index-url http://myindexurl.com",
Expand Down Expand Up @@ -88,6 +90,8 @@ Deployment complete!
"client": "1",
"dependencies": [
"-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
"-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
"-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
"-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
"-i http://myindexurl.com",
"--index-url http://myindexurl.com",
Expand Down
3 changes: 3 additions & 0 deletions bundle/libraries/local_path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ import (
// - s3:/mybucket/myfile.txt
// - /Users/jane@doe.com/myfile.txt
func IsLocalPath(p string) bool {
// Trim single or double quotes from the path
p = strings.Trim(p, `"'`)

// If the path has the file:// scheme, it's a runtime path (remote).
// Users should use relative paths without scheme for local files to upload.
if strings.HasPrefix(p, "file://") {
Expand Down
2 changes: 2 additions & 0 deletions bundle/libraries/local_path_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ func TestIsLocalPath(t *testing.T) {
assert.True(t, IsLocalPath("myfile.txt"))
assert.True(t, IsLocalPath("./myfile.txt"))
assert.True(t, IsLocalPath("../myfile.txt"))
assert.True(t, IsLocalPath("'some/local/path'"))
assert.True(t, IsLocalPath("\"some/local/path\""))

// Absolute paths without scheme (remote).
assert.False(t, IsLocalPath("/some/full/path"))
Expand Down