Skip to content

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Feb 12, 2026

tested with ./mill bench.runRegressions

Copilot AI review requested due to automatic review settings February 12, 2026 12:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the benchmark suite to use the current sjsonnet importer API, fixing compilation/runtime wiring after the prior resolveImport-based approach became unavailable.

Changes:

  • Replaced SjsonnetMainBase.resolveImport(...) calls with new SjsonnetMainBase.SimpleImporter(...) in benchmark/profiler entrypoints.
  • Standardized importer construction to pass ordered jpaths plus allowedInputs = None.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
bench/src/sjsonnet/bench/RunProfiler.scala Switches profiler runner to construct an importer via SimpleImporter directly.
bench/src/sjsonnet/bench/MaterializerBenchmark.scala Updates benchmark interpreter setup to use SimpleImporter instead of resolveImport.
bench/src/sjsonnet/bench/MainBenchmark.scala Updates main benchmark interpreter setup to use SimpleImporter instead of resolveImport.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant