Conversation
arunpamulapati
left a comment
arunpamulapati
left a comment
There was a problem hiding this comment.
Approving on behalf of Alex as per slack
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Databricks Add-on for Splunk from version 1.2.0 to version 1.4.2. The upgrade includes significant architectural changes to how run execution data is managed, transitioning from KV store-based logging to index-based event logging, along with extensive updates to the Splunk SDK libraries and UI enhancements.
Changes:
- Migration from KV store collections to index-based event storage for run execution tracking
- Addition of run status monitoring via the
databricksrunstatuscommand - UI enhancements including run cancellation functionality and improved execution status tracking
- Upgrade of Splunk SDK from version 1.7.1 to 1.7.3
- Addition of new configuration parameters for query execution and admin commands
Reviewed changes
Copilot reviewed 38 out of 110 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_databricksrun.py | Updated tests to reflect index-based storage and added new mock configurations |
| test_databricksretiredrun.py | Removed entire test file as the retire run functionality has been replaced |
| test_databricksquery.py | Enhanced test mocking for configuration retrieval |
| test_databricksjob.py | Updated assertions to match new response structure |
| test_alert.py | Improved test parameter mocking with explicit function definitions |
| test_databricks_common_utils.py | Updated version assertion and removed KV store tests |
| .coveragerc | Lowered coverage threshold from 80% to 60% |
| app/default/* | Removed KV store configurations, added new endpoints and settings |
| app/bin/ta_databricks/aob_py3/splunklib/* | Added extensive Splunk SDK library modules |
| app/default/data/ui/views/* | Enhanced dashboards with cancel functionality and status tracking |
| notebook.py | Minor comment correction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| service.post(ENDPOINT_URL, fields, function (err, response) { | ||
| if (response != undefined && (response.data != null || response.data != undefined)) { | ||
| canceled_response = response.data['canceled'] |
There was a problem hiding this comment.
Variable canceled_response is used like a local variable, but is missing a declaration.
| canceled_response = response.data['canceled'] | |
| var canceled_response = response.data['canceled']; |
|
|
||
| service.post(ENDPOINT_URL, fields, function (err, response) { | ||
| if (response != undefined && (response.data != null || response.data != undefined)) { | ||
| canceled_response = response.data['canceled'] |
There was a problem hiding this comment.
Avoid automated semicolon insertion (95% of all statements in the enclosing function have an explicit semicolon).
3 participants
No description provided.