fix: prevent conflicting dry-run flags with Helm v4 (#894) #927
+19
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using helm-diff with Helm v4.0.0, code was adding both --dry-run=server (for validation) and --dry-run=client (default for helm template), creating a conflict. This caused .Capabilities.APIVersions.Has to be incorrectly evaluated, resulting in incorrect diff output. Changes: - Add helper function getValidateFlag() to avoid code duplication - Only return --validate flag for Helm v3 (not v4) when validation is enabled - Remove the logic that adds --dry-run=server for validation in Helm v4 - Add --dry-run=client for Helm v4 when using helm upgrade --dry-run (when HELM_DIFF_UPGRADE_DRY_RUN is set and version doesn't support dry-run lookup) - Simplify comments in helm template section This fixes the issue where .Capabilities.APIVersions.Has was incorrectly filled when using Helm v4.0.0, which caused helm-diff to incorrectly show code blocks as deleted when they should not be. Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using helm-diff with Helm v4.0.0, code was adding both --dry-run=server (for validation) and --dry-run=client (default for helm template), creating a conflict. This caused .Capabilities.APIVersions.Has to be incorrectly evaluated, resulting in incorrect diff output.
Changes:
This fixes the issue where .Capabilities.APIVersions.Has was incorrectly filled when using Helm v4.0.0, which caused helm-diff to incorrectly show code blocks as deleted when they should not be.