fix: use --dry-run=server by default for Helm v4 to fix .Capabilities.APIVersions #928
+30
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….APIVersions For Helm v4, --dry-run=server should be used by default to get the correct .Capabilities.APIVersions.Has behavior. This is only applied when the user hasn't explicitly set --dry-run=client. Fixes #894 Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #894
For Helm v4,
--dry-run=servershould be used by default to get the correct.Capabilities.APIVersions.Hasbehavior. Without this, conditions like{{ if .Capabilities.APIVersions.Has "monitoring.coreos.com/v1/PrometheusRule" }}are incorrectly evaluated by helm-diff when using Helm v4.0.0.Changes
cmd/helm.goto use--dry-run=serverby default for Helm v4 when the user hasn't explicitly set--dry-run=client--dry-runarguments for Helm v4Testing
All existing tests pass.