Conversation
nblumhardt
left a comment
There was a problem hiding this comment.
Looks great, thanks, just some minor comments.
I think this should still go under events delete; although it would be the odd one out right now, it's a fringe scenario (retention policies are preferred and perform much better), while the top-level commands are generally for day-to-day scenarios. It's also possible we'll end up with a metrics delete in the future.
(If I could go back in time I'd probably not put any commands at the root level, but that ship sailed long ago 😅 .)
I kind of sensed that. Still, I wanted to remain explicit with my decision process and provoke exactly the discussion we are having here 😅
Yup, that's a good idea indeed and regarding your other feedback, good one, thanks. I will refactor the PR tomorrow (I'm in CET). |
49014ee to
57410c1
Compare
seqcli delete commandseqcli events delete command
57410c1 to
8503562
Compare
|
Hi @nblumhardt, I may be lacking some .NET fu here, but I'm not sure why the $ dotnet run -- EventsDelete.* --docker-server --verbose
Using launch settings from /home/mloskot/workshop/seq/seqcli/test/SeqCli.EndToEnd/Properties/launchSettings.json...
TESTING /home/mloskot/workshop/seq/seqcli/src/SeqCli/bin/Debug/net10.0/seqcli.dll
Done; 0 total, 0 passed, 0 failed, 0 skipped. |
The `events delete` command is modelled after the `seqcli search` and accepts date range as well as filter expressions. The `events delete` command is covered with e2e tests. The idea of adding delete command came up in this thread: - datalust/seq-tickets#2529 Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
8503562 to
1128e7a
Compare
The
events deletecommand is modelled after theseqcli searchand accepts date range as well as filter expressions.The
events deletecommand is covered with e2e tests.The idea of adding delete command came up in this thread:
seqcli deleteorseqcli events deleteSince theresearchandingestare not sub-commands ofseqcli events, I decided to follow the convention and addseqcli deleteinstead ofseqcli events delete.I eventually refactored the command into
seqcli events delete, see discussion in #445 (review)Testing
I have also tested
seqcli events deleteagainst live server running Seq 2025.2.15571.Examples