Liberally accept literal DSN arguments to --dsn#1589
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Liberally accept literal DSN arguments to --dsn#1589rolandwalker wants to merge 1 commit intomainfrom
--dsn#1589rolandwalker wants to merge 1 commit intomainfrom
Conversation
|
Findings
No security issues or correctness regressions jumped out in the code paths touched. Suggested next steps
|
769fcea to
9505a68
Compare
Forgive the user for thinking that --dsn can accept a literal DSN in addition to an alias. Internally, recast the confusing variable name "dsn" to "dsn_alias".
9505a68 to
1774657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forgive the user for thinking that
--dsncan accept a literal DSN in addition to an alias.Internally, recast the confusing variable name
dsntodsn_alias.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).