This repository was archived by the owner on May 10, 2025. It is now read-only.
Include top of the stacktrace in error embed for emblem command#208
Open
FlaminSarge wants to merge 1 commit intodevFelicity:mainfrom
Open
Include top of the stacktrace in error embed for emblem command#208FlaminSarge wants to merge 1 commit intodevFelicity:mainfrom
FlaminSarge wants to merge 1 commit intodevFelicity:mainfrom
Conversation
This is the only place that the exception is directly logged to clients with the intent for them to open an issue on GitHub, so may as well give them more information to submit.
Collaborator
|
Hello, I greatly appreciate your contribution but this project is no longer in active development. I forgot to make a note of this in the repo I apologize. Will definitely be using this tip in future projects, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only place that the exception is directly logged to clients with the intent for them to open an issue on GitHub, so may as well give them more information to submit.
The alternative to this would be:
Generate a GUID for the exception.
Log the exception + GUID.
Display the GUID to client in the ErrorEmbed, for them to log an issue on Discord/GitHub.
I do not know if the stack trace will contain any sensitive info from the bot host, hence the alternative proposal.