12 changed into {{ env.version }}

[sahapasci]

This pull request updates the PostgreSQL Dockerfile by replacing hardcoded version numbers (12) with the environment variable {{ env.version }}. I believe that updating the documentation links is a good idea as PostgreSQL version 12 is approaching its end of support.

[yosifkit]

Thanks! LGTM

[tianon]

The reason this is tagged to a specific version is because the server-start.html page might go away or move elsewhere in the future -- it's not guaranteed to exist for every version we support, and we certainly don't want to maintain a conditional here just to make the URL point to a page that exists for the given version we're generating.

It's similar in spirit to linking to a markdown file on a GitHub branch vs a "permalink" to a commit.

So, if there's a newer version of this page we can link to, I'm happy to accept that change, but updating it to something that automatically (blindly) updates the URL is a no-go for me. 😇 ❤️

[sahapasci]

<sect1 id="server-start"> in runtime.sgml hasn't changed in 20 years.