Open
Conversation
* move `test/unit/command_line_test` to `test/integration/test_command_line` * require `test_helper` in all test files and require `test/unit` in test_helper this allows any test file to be run individually as: `ruby test/unit/test_uglifier.rb` * modify `test/unit/jammit_helpers` to force rails 2.3 compatibility with ruby 1.9.3 * modify `test/integration/test_command_line` to resolve asset paths correctly, and to make debugging a bit easier (still has a couple failing tests) * modify `test/configuration` to work with ruby 1.9's unicode-by-default strings
* explicitly ignore Gemfile.lock * update sass to work with 6f0c096 * change redgreen require (from b6dd1b1) to always require - it should be present after `bundle install`, and the `Gem` method isn't supported in all environments * add yard as a development dependency * require rubygems explicitly, to avoid weirdness in some environments * only declare Jammit::VERSION in one place * remove `sudo` from rake tasks - it doesn't play well with tools like rvm, and it's easy to run the whole command as sudo
* isolate Jammit::VERSION into single file (easy to require) * remove redgreen from Rakefile (contentious?) * remove -rrubygems from bin/jammit - use inline require * use `bundle exec` path in tests
1) mtime was not being modified when `--force` was set on command line This has now been fixed - the force option now overrides Jammit's mtime niceties 2) newlines for JSTs were improperly described in the tests - the JS file, including templates and the JST definition, have all literal newlines stripped, but newlines inside of strings (in the templates themselves) are not stripped. Since calling jammit on the CLI treats the whole output as a JS file, the fixture for the `pack_templates` unit test was not appropriate for the CLI test
Author
|
I'm liking the Travis integration here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes intended to make Jammit easier to hack on, and easier to run in Ruby 1.9. Details are summarized in the commit messages, but the main things are making the tests 1.9 compatible and making dependencies explicit (and/or updated).