Change python_Serpent implementation#6
Open
koujiandou-mhfg wants to merge 5 commits intodoegox:python3from
Open
Change python_Serpent implementation#6koujiandou-mhfg wants to merge 5 commits intodoegox:python3from
koujiandou-mhfg wants to merge 5 commits intodoegox:python3from
Conversation
http://blog.bjrn.se/2008/01/truecrypt-explained.html > These implementations are converted directly from the C code and are > thus very ugly Python, but the code works although it's slow.
I used the code below as reference. https://github.com/jackspirou/libmcrypt/blob/master/modules/algorithms/serpent.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python_Serpentuses pyserpent.py found on http://www.cl.cam.ac.uk/~fms27/serpent/. It is human readable but extremely slow.I replaced pyserpent.py with serpent.py. Though the writer of this code says "These implementations are converted directly from the C code and are thus very ugly Python, but the code works although it’s slow," it is 250x faster than pyserpent.py I expect.
I made it more readable on 2086c20, it still runs 200x faster than pyserpent.py.
In the same way as #5, new version of serpent.py runs on Python 2.7 and Python 3.5.