#190 fix "Cannot read property 'headers' of undefined"#191
Open
d9k wants to merge 1 commit intodriverdan:masterfrom
Open
#190 fix "Cannot read property 'headers' of undefined"#191d9k wants to merge 1 commit intodriverdan:masterfrom
d9k wants to merge 1 commit intodriverdan:masterfrom
Conversation
This was referenced Jul 29, 2021
|
This is actually a very important PR. Can someone please review it? It only has a couple of lines changed, and changed in such a way that it actually reads the response headers instead of a makeshift hack around setting a global Not to mention that global variables are substantially more prone to bugs than generated/object instance fields. i.e. |
Dog05skate
approved these changes
Apr 10, 2022
|
Can this get merged in or are no new releases planned? |
Dog05skate
approved these changes
Sep 10, 2022
Dog05skate
approved these changes
Sep 10, 2022
| for (var i in headers) { | ||
| // Cookie headers are excluded | ||
| if (i !== "set-cookie" && i !== "set-cookie2") { | ||
| result += i + ": " + response.headers[i] + "\r\n"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.