Conversation
--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : PEP8 Standards Fixes Done : 3-16-17 --------- END META VARIABLES --------
posita
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Please consider updating the flake8 section of tox.ini and the MESSAGES CONTROL section of .pylintrc to reflect the changes. This will likely mean turning back on certain linter options, but some experimentation may be necessary.
| print("Finding available revisions on Dropbox...") | ||
| entries = dbx.files_list_revisions(BACKUPPATH, limit=30).entries # pylint: disable=no-member | ||
| entries = dbx.files_list_revisions( | ||
| BACKUPPATH, limit=30).entries # pylint: disable=no-member |
There was a problem hiding this comment.
Breaking up this line confuses the linter. Consider instead:
revisions = dbx.files_list_revisions(BACKUPPATH, limit=30)
entries = revisions.entries # pylint: disable=no-member--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : Cleaning up backup-and-restore-example.py Done : 3-16-17 --------- END META VARIABLES --------
--------- BEGIN META VARIABLES -------- Project : dropbox-sdk-python Task : Addressing linter error on travis CI build for prior commit to backup-and-restore-example.py Done : 3-16-17 --------- END META VARIABLES --------
Project : dropbox-sdk-python Task : Updating tox.ini to ignore E1101 (no-member) Done : 3-16-17 --------- END META VARIABLES --------
|
Hey Matt, my pleasure. Broke up the revision retrieval code, and fixed a subsequent E261 error. Also added E1101 to tox.ini, it looks like MESSAGES CONTROL for .pylintrc already has locally-disabled disabled. |
posita
left a comment
There was a problem hiding this comment.
@Dmchale92, it looks good. If you can squash commits, I'll merge. Thanks!
|
As an aside, |
f2cf463 to
afadb2d
Compare
|
Hello, If you are still interested in updating this piece of code, please acknowledge this message and make the necessary updates. |
|
|
--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : PEP8 Standards Fixes
Done : 3-16-17
--------- END META VARIABLES --------