add const to lmdb::dbi::get (for consistency)#19
Open
fcelda wants to merge 1 commit intodrycpp:masterfrom
fcelda:dbi-get-const
Open
add const to lmdb::dbi::get (for consistency)#19fcelda wants to merge 1 commit intodrycpp:masterfrom fcelda:dbi-get-const
fcelda wants to merge 1 commit intodrycpp:masterfrom
fcelda:dbi-get-const
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change adds
constqualifier to onelmdb::dbi::lastoverload to be consistent with other ones. I think this was simply a typo and that there is no reason to keep the method non-const. The current state creates some confusion when the overloads are being resolved.