Implement FileUpload component#269
Open
emir89 wants to merge 5 commits intofeature/createFileUploadComponentForBetterUppyUsage-CMEM-5925from
Open
Implement FileUpload component#269emir89 wants to merge 5 commits intofeature/createFileUploadComponentForBetterUppyUsage-CMEM-5925from
emir89 wants to merge 5 commits intofeature/createFileUploadComponentForBetterUppyUsage-CMEM-5925from
Conversation
haschek
requested changes
Apr 29, 2025
| import "@uppy/drag-drop/dist/style.css"; | ||
| import "@uppy/progress-bar/dist/style.css"; | ||
|
|
||
| export interface FileUploadProps extends TestableComponent { |
Member
There was a problem hiding this comment.
FileUploadProps probaby should extend also Uppy and HTMLDivElement. Or is there a reason not to do so?
Properties forwarded to Uppy could also be included by the uppyProps pattern that we use also in other components. This way it is more distinct what are our properties, what properties come from Uppy.
Contributor
Author
There was a problem hiding this comment.
I didn't notice the particular reason for this, but if it makes more sense according to the certain pattern, then sure it should be adjusted.
haschek
requested changes
Jun 4, 2025
| } | ||
|
|
||
| export const FileUpload: FC<FileUploadProps> = ({ | ||
| export { ProgressBar as UppyProgressBar, DragDrop } from "@uppy/react"; |
Member
There was a problem hiding this comment.
Should be exported as FileUploadProgressBar and FileUploadDragDrop.
haschek
changed the base branch from
develop
to
feature/createFileUploadComponentForBetterUppyUsage-CMEM-5925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.